Fix "WPF- OxyPlot doesn't render inside a Popup" (#1796)#1797
Conversation
update changelog Fix "WPF- OxyPlot doesn't render inside a Popup" (oxyplot#1796)
There was a problem hiding this comment.
I've tested and the fix looks good to me.
We probably need an example (so that it's easier to test in future); I put a simple example together in https://github.com/VisualMelon/oxyplot/tree/bugfix-wpf-popup which we could use, but if you have a better idea for a use-case that involves popups that would be welcome!
| # Change Log | ||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
Should ideally have the unrelease/added/changed/fixed/removed sections like in https://raw.githubusercontent.com/oxyplot/oxyplot/StemSeriesActualMarker/CHANGELOG.md , but we can do that separately
|
(Note to self: need to check the Skia stuff as well) |
|
Fixed Skia stuff in my branch, and added a pointless/fun popup pre-view for the example browser (so we can accidently test popups and Skia scaling at the same time, all the time) |
VisualMelon
left a comment
VisualMelon
left a comment
There was a problem hiding this comment.
I think I'm happy to merge this; need separate PRs for:
- Skia Fix
- Example of some sort...
- Re-start changelog
Will leave it a little longer for the other maintainers to take a look.
|
I'm happy my PR was useful :) Sorry for the changelog, did my best. Adding a popup in the examples is a great idea 👍 |
|
Just to keep you in the loop, I'm somewhat indisposed at the moment, and don't want to hit merge until I have the energy to follow up with the other bits properly. Hopefully I'll be back in action some time in the next few days. |
|
Looks good to me, no objections to merging this.
Sounds great! I am wondering: The code until now assumed that at the root of the visual tree is always a |
|
I am currently testing a solution for ElementHosts with the code provided in this PR. The only addition to this would be to also match to AdornerDecorators in IsInVisualTree. Although i have to test this a little be more. Please check #1800 for reference. |
|
@AELIENUS thanks for following that up! |
4 participants
Fix "WPF- OxyPlot doesn't render inside a Popup" (#1796)
Fixes #1796 .
Checklist
Changes proposed in this pull request:
@oxyplot/admins