Fix example build errors in certain code pages#1890
Merged
Conversation
myd7349
force-pushed
the
fix-example-build-errors
branch
from
818d105 to
ae5dd74
Compare
Contributor
|
Not sure I understand the issue, but doesn't seem to break anything, so I'm happy for this to be merged. |
Currently, these three files have an ANSI encoding:
- Source/Examples/ExampleLibrary/Annotations/ArrowAnnotationExamples.cs
- Source/Examples/ExampleLibrary/Annotations/TextAnnotationExamples.cs
- Source/Examples/ExampleLibrary/Examples/RenderingCapabilities.cs
which will cause build errors in certain code pages.
For example, in iso-8851-1 and cp936, degree symbol is not the same:
>>> '°'.encode('iso-8859-1')
b'\xb0'
>>> '°'.encode('cp936')
b'\xa1\xe3'
and when it comes to cp936, it can not understand '0xb0' correctly.
Solution:
Change encoding of these three files from ANSI to UTF-8 with BOM.
myd7349
force-pushed
the
fix-example-build-errors
branch
from
ae5dd74 to
2fc2919
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, these three files have an ANSI encoding:
which will cause build errors in certain code pages.
In iso-8859-1 and cp936, degree symbol is not the same:
and when it comes to cp936, it can not understand '0xb0' correctly.
Checklist
Changes proposed in this pull request:
@oxyplot/admins