You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#1900 by adding properties to PathAnnotation that match the functionality of TextAnnotation. Decided to not try to put everything in TextualAnnotation because there would be naming issues, as the same names are used in PathAnnotation and TextAnnotation already for different purposes.
Checklist
I have included examples or tests
I have updated the change log
I am listed in the CONTRIBUTORS file
I have cleaned up the commit history (use rebase and squash)
Changes proposed in this pull request:
Add four new properties to PathAnnotation:
TextBackground
TextBackgroundStroke
TextBackgroundStrokeThickness
TextBackgroundPadding
@colejonson66 suggested Border for the stroke properties as an alternative to Background, which may be a better name.
@oxyplot/admins does this API look OK? Not wild about ChangeOpacity now that I look at it again, but can remove that and keep the other changes otherwise.
Any preference between Border/Background for naming per ermakrs from @colejonson66 ?
Border sounds more adequate at first, however the property TextBackground doesn't make sense when renamed to TextBorder. I guess we'd have to do TextBorderBackground then. TextBorderStroke, TextBorderStrokeThickness and TextBorderPadding would be fine however.
Currently I would tend to leaving it at Background, but could be convinced otherwise.
ChangeOpacity is fine in my opinion, ChangeAlpha could also work.
Looking at this quickly now, I'm tempted again by TextBorderStroke and TextBorderThickness, leaving everything else as is. If that's agreeable, then I'll make that change and I think we should get this merged.
Then I don't like TextBackgroundPadding... I think TextBorderBackground is OK, so I've changed to Border everything (rather than TextBackground and rebased. I don't know if you're convinced by the new naming, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1900 by adding properties to
PathAnnotationthat match the functionality ofTextAnnotation. Decided to not try to put everything inTextualAnnotationbecause there would be naming issues, as the same names are used inPathAnnotationandTextAnnotationalready for different purposes.Checklist
Changes proposed in this pull request:
PathAnnotation:TextBackgroundTextBackgroundStrokeTextBackgroundStrokeThicknessTextBackgroundPadding@colejonson66 suggested
Borderfor the stroke properties as an alternative toBackground, which may be a better name.@oxyplot/admins