Skip to content

Flow updates#512

Merged
amadeus merged 2 commits into
developfrom
flow-updates
Jun 26, 2016
Merged

Flow updates#512
amadeus merged 2 commits into
developfrom
flow-updates

Conversation

@amadeus

@amadeus amadeus commented Jun 26, 2016

Copy link
Copy Markdown
Collaborator

Misc fixes for the JS Flow plugin.

@amadeus amadeus merged commit dbfa5f0 into develop Jun 26, 2016
@amadeus amadeus deleted the flow-updates branch June 26, 2016 00:08
@gf3

gf3 commented Jun 28, 2016

Copy link
Copy Markdown
Contributor

getting some leakage from jsFlowTypeObject after this last merge:

screen shot 2016-06-28 at 2 24 19 pm

@gf3

gf3 commented Jun 28, 2016

Copy link
Copy Markdown
Contributor

if you add ; to the end regex of jsFlowTypeValue it works as expected

@amadeus

amadeus commented Jun 28, 2016

Copy link
Copy Markdown
Collaborator Author

Can you create a new issue with a quick example broken snippet? I'll get on fixing these ASAP.

@gf3

gf3 commented Jun 28, 2016

Copy link
Copy Markdown
Contributor

i'll open a PR in a couple mins

@amadeus

amadeus commented Jun 28, 2016

Copy link
Copy Markdown
Collaborator Author

@gf3 I do have a branch I am fixing a couple things in currently, so I may have already fixed this issue in that branch.

@gf3

gf3 commented Jun 28, 2016

Copy link
Copy Markdown
Contributor

okay, issue created → #517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants