test: add describe_operation tests for PatchApply variants#608
Merged
Conversation
The explain command's describe_operation for PatchApply was a static string that ignored on_stale and allow_conflicts parameters added in #587/#602. Fixed the description to include these when non-default, and added 6 new tests covering: - PatchApply default, merge-on-stale, allow-conflicts, both - Replace with glob instead of path - Replace with to: None (delete mode) Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 6 unit tests for the
describe_operationfunction inexplain.rs:describe_patch_apply_default: verifies static string for default PatchApplydescribe_patch_apply_merge_on_stale: verifies "merge on stale" suffixdescribe_patch_apply_allow_conflicts: verifies "allow conflicts" suffixdescribe_patch_apply_merge_and_conflicts: verifies both combineddescribe_replace_glob_no_path: verifies glob fallback in Replace describedescribe_replace_delete_mode: verifiesto: Noneshows "(delete)"Also fixes the
PatchApplyvariant to actually includeon_staleandallow_conflictsin the describe output when non-default, matching the behavior of other operation variants.