feat(Slider): consumed Penta tokens#6157
Conversation
thatblindgeye
requested review from
a team,
andrew-ronaldson,
mcoker and
srambach
and removed request for
a team
|
Preview: https://patternfly-pr-6157.surge.sh A11y report: https://patternfly-pr-6157-a11y.surge.sh |
| --#{$slider}__thumb--before--Height: var(--#{$pf-global}--target-size--MinHeight); | ||
| --#{$slider}__thumb--before--BorderRadius: var(--#{$pf-global}--BorderRadius--lg); | ||
| 0 0 2px 5px var(--pf-t--global--color--nonstatus--blue--clicked); | ||
| --#{$slider}__thumb--before--Width: 44px; |
There was a problem hiding this comment.
My only question is whether we want to keep using the global target size here (maybe just for now) and I would guess we might want to make this a dimension token in the future?
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
I saw the height of the rail is 0.25rem which technically matches the token but wanted to see if we are explicitly defining the variables as px or rem.
| --#{$slider}__thumb--TranslateX: -50%; | ||
| --#{$slider}__thumb--TranslateY: -50%; | ||
| --#{$slider}__thumb--BorderRadius: var(--#{$pf-global}--BorderRadius--lg); | ||
| --#{$slider}__thumb--BorderRadius: var(--pf-t--global--border--radius--large); |
There was a problem hiding this comment.
I think a circle border radius would be useful - cc @lboehling. The value would be "50%" and it will make any square a circle, regardless of size.
|
🎉 This PR is included in version 6.0.0-alpha.49 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 participants
Work towards #5738