feat(Card): apply tokens#6187
Merged
Merged
Conversation
Closed
Collaborator
|
Preview: https://patternfly-pr-6187.surge.sh A11y report: https://patternfly-pr-6187-a11y.surge.sh |
srambach
requested review from
a team,
andrew-ronaldson,
mattnolting and
mcoker
and removed request for
a team
andrew-ronaldson
approved these changes
Jan 11, 2024
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks Sarah!
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.62 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6186
One known problem - this demo shows a popover that would need to be attached differently in React so that it can escape the bounding box. @mcoker should we remove this demo, or is there a way to fix it in core?