feat(CopyClipboard): apply tokens#6198
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6198.surge.sh A11y report: https://patternfly-pr-6198-a11y.surge.sh |
srambach
reviewed
Jan 11, 2024
srambach
left a comment
srambach
left a comment
Member
There was a problem hiding this comment.
🥳 Looks great! Just one token missing I think.
mcoker
reviewed
Jan 11, 2024
| --#{$clipboard-copy}__expandable-content--BorderRadius: var(--pf-t--global--border--radius--small); | ||
| --#{$clipboard-copy}__expandable-content--OutlineOffset: var(--pf-t--global--spacer--xs); | ||
| } | ||
| .#{$clipboard-copy} { |
Contributor
There was a problem hiding this comment.
Starting about here it looks like some CSS vars need to eb moved to the block above, to about lin e41
Missed content in the :where + :root section
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
mcoker
approved these changes
Jan 12, 2024
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
thatblindgeye
approved these changes
Jan 12, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.60 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6194