feat(InputGroup,TextInput): add tokens#6201
Conversation
|
Preview: https://patternfly-pr-6201.surge.sh A11y report: https://patternfly-pr-6201-a11y.surge.sh |
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
Looks great! One question about the pf-m-box variant.
| --#{$input-group}__item--m-box--PaddingRight: var(--pf-t--global--spacer--sm); | ||
| --#{$input-group}__item--m-box--PaddingLeft: var(--pf-t--global--spacer--sm); | ||
| --#{$input-group}__item--m-box--BackgroundColor: var(--pf-t--global--background--color--secondary--default); | ||
| --#{$input-group}__item--m-box--BorderWidth: var(--#{$input-group}__item--BorderWidth--base); | ||
| --#{$input-group}__item--m-box--BorderRadius: var(--pf-t--global--border--radius--small); | ||
| --#{$input-group}__item--m-box--BorderTopColor: var(--#{$input-group}__item--BorderColor--base); | ||
| --#{$input-group}__item--m-box--BorderRightColor: var(--#{$input-group}__item--BorderColor--base); | ||
| --#{$input-group}__item--m-box--BorderBottomColor: var(--#{$input-group}__item--BorderColor--accent); | ||
| --#{$input-group}__item--m-box--BorderBottomColor: var(--#{$input-group}__item--BorderColor--base); | ||
| --#{$input-group}__item--m-box--BorderLeftColor: var(--#{$input-group}__item--BorderColor--base); |
There was a problem hiding this comment.
Looks like this is broken. Should we remove the variant?
There was a problem hiding this comment.
That's used to put the extra things around it, like the $ or "@example.com"
I think we still want that?
|
LGTM!! thank you @srambach I did notice some weird things happening in the toolbar demos, but i'm guessing that's because the examples aren't using input group? should they be? |
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
WooHoo! LPTM, great work 🎉
|
🎉 This PR is included in version 6.0.0-alpha.52 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
Fixes #6191
Also adjusts a padding on the form element because it was too close to the status icon.
I can combine the borders into one variable if desired.
Convenience links to some things affected:
https://patternfly-pr-6201.surge.sh/components/number-input
https://patternfly-pr-6201.surge.sh/components/input-group
https://patternfly-pr-6201.surge.sh/components/text-input-group