fix(tree-view): add tokens#6284
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6284.surge.sh A11y report: https://patternfly-pr-6284-a11y.surge.sh |
mcoker
requested review from
andrew-ronaldson,
lboehling,
srambach and
thatblindgeye
srambach
approved these changes
Feb 9, 2024
srambach
left a comment
srambach
left a comment
Member
There was a problem hiding this comment.
I don't see any problems, good questions posed in the description. 🌴
wise-king-sullyman
requested changes
Feb 9, 2024
| --#{$tree-view}__node-toggle-button--MarginTop: calc(var(--#{$pf-global}--spacer--form-element) * -1); | ||
| --#{$tree-view}__node-toggle-button--MarginBottom: calc(var(--#{$pf-global}--spacer--form-element) * -1); | ||
| --#{$tree-view}__node-toggle-icon--MinWidth: var(--pf-t--global--icon--size--body--default); | ||
| --#{$tree-view}__node-toggle-icon--MinWidth: var(--pf-t--global--icon--size--body--default); |
andrew-ronaldson
approved these changes
Feb 9, 2024
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks good. Navigation has similar spacing to this tree-view so we could align on this instead. We can deal with that in another PR. Ship it!
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.78 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convenience link to tree view component
fixes #5723
<button>element except for in a checkbox tree-view, otherwise it's just an icon inside of the tree view node, and the node is a<button>.