chore(tokens): update tokens with new status colors and border on secondary#6452
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6452.surge.sh A11y report: https://patternfly-pr-6452-a11y.surge.sh |
mcoker
reviewed
Mar 22, 2024
Comment on lines
+7
to
+11
| --pf-t--chart--stroke--width--sm: 2; | ||
| --pf-t--chart--stroke--width--xs: 1; | ||
| --pf-t--chart--BorderWidth--lg: 8; | ||
| --pf-t--chart--BorderWidth--sm: 2; | ||
| --pf-t--chart--BorderWidth--xs: 1; |
Contributor
There was a problem hiding this comment.
@lboehling just want to confirm this is an intended change? It's good from the code side since the existing values are unitless and passed directly to SVG attributes/styles
Member
Author
There was a problem hiding this comment.
It's exported as
"xs": {
"type": "number",
"value": 1
},
"sm": {
"type": "number",
"value": 2
},
"lg": {
"type": "number",
"value": 8
}
},
"stroke": {
"width": {
"xs": {
"type": "number",
"value": 1
},
"sm": {
"type": "number",
"value": 2
}
}
},
and I thought you wanted unitless, so the dimension isn't added by the transformer right now.
Contributor
There was a problem hiding this comment.
@srambach perfect! Just wanted to verify it was intentional 👍
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.105 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to tokens from design. Modifies status colors and adds a border color on secondary.