fix(layouts): applied tokens#6453
Conversation
|
Preview: https://patternfly-pr-6453.surge.sh A11y report: https://patternfly-pr-6453-a11y.surge.sh |
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
I see some mixture of v5 and v6 in the examples and docs of flex, grid, and gallery. Do you want to change that now or catch it in the upcoming PR for all the v5s?
| .ws-core-l-bullseye .pf-v6-l-bullseye, | ||
| .ws-core-l-bullseye .pf-v6-l-bullseye__item { | ||
| padding: .5rem; | ||
| border: 2px dashed #393f44; |
There was a problem hiding this comment.
On the borders for the examples, do you want to use a token so that it works better in dark theme? Maybe also the border width just because?
There was a problem hiding this comment.
Yep! Superb suggestion.
| @@ -10,7 +10,7 @@ | |||
| @each $property, $property-value in $pf-v5-global--spacer-properties-map { | |||
There was a problem hiding this comment.
Do you want to go ahead and change this to v6 here and on line 295 of scss-variables.scss?
|
@srambach I'll make that update in this PR 👍👍 |
srambach
left a comment
srambach
left a comment
There was a problem hiding this comment.
The examples look beautiful with the tokens applied!
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Couple comments below, nothing blocking here though
| .#{$flex} { | ||
| // Emit spacer css variables that map to requested spacer values | ||
| @include pf-v5-emit-properties($pf-v5-l-flex--variable-map); | ||
| @include pf-v5-emit-properties($pf-v6-l-flex--variable-map); |
There was a problem hiding this comment.
Is there a TODO regarding updating mixins used in these layouts to a v6 prefix?
| $pf-v5-l-flex--spacer-map: build-spacer-map(); | ||
| $pf-v5-l-flex--gap-map: build-spacer-map("base", "none", "xs", "sm", "md", "lg", "xl", "2xl", "3xl", "4xl"); | ||
| $pf-v5-l-flex--variable-map: build-variable-map("#{$pf-prefix}l-flex--spacer", $pf-v5-l-flex--spacer-map); | ||
| $pf-v6-l-flex--breakpoint-map: build-breakpoint-map(); |
There was a problem hiding this comment.
Not a blocker for this, but would we be able to use the pf-prefix instead of hardcoding the version number in these files
|
🎉 This PR is included in version 6.0.0-alpha.107 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
fixes #6316