Skip to content

fix(card): clean up utility classes in demos#6497

Merged
mcoker merged 1 commit into
patternfly:v6from
srambach:6496-update-card-demo-icons-timestamp
Apr 1, 2024
Merged

fix(card): clean up utility classes in demos#6497
mcoker merged 1 commit into
patternfly:v6from
srambach:6496-update-card-demo-icons-timestamp

Conversation

@srambach

@srambach srambach commented Apr 1, 2024

Copy link
Copy Markdown
Member

Replaces some utility class use with the timestamp component and icon component. Also removes an un-supported light font weight.

Fixes #6496

@patternfly-build

patternfly-build commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator

<i class="fas fa-exclamation-circle pf-v6-u-icon-color-status-success" aria-hidden="true"></i>
{{#> icon}}
{{#> icon-content icon-content--modifier="pf-m-success"}}
<i class="fas fa-check-circle" aria-hidden="true"></i>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the wrong icons being used here, especially this one!

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🎃TM!

@mcoker mcoker merged commit 18db650 into patternfly:v6 Apr 1, 2024
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.0.0-alpha.115 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants