chore(datalist): reduce mobile borders to 2px#6615
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6615.surge.sh A11y report: https://patternfly-pr-6615-a11y.surge.sh |
mcoker
requested changes
May 8, 2024
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
Looks like there is a semantic token that fits the bill here
The --[100-900] (or whatever the range is) tokens are what we refer to as "base" tokens (similar to color palette vars) and in general we try to avoid using them unless there is no other/more appropriate semantic variable available.
Member
Author
|
@mcoker thanks for the help finding the best token (and the additional context), updates made based on your suggestions 👍 |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.124 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6555
This PR updates the default DataList and DataListItem borders from
--pf-t--global--spacer--smto--pf-t--global--border--width--strong