fix(tokens): rename file and add no-motion modifier#6711
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6711.surge.sh A11y report: https://patternfly-pr-6711-a11y.surge.sh |
mcoker
approved these changes
May 29, 2024
Comment on lines
+150
to
+151
| .pf-m-no-motion { | ||
| // Set all motion tokens to 0 for testing purposes |
Contributor
There was a problem hiding this comment.
From the comment that it's for testing, this may not be relevant, but I think a good place for this would be patternfly-common.scss. And just a thought, but if this should stomp on all animations, I wonder if we should consider adding !important to these declarations?
Member
Author
There was a problem hiding this comment.
I debated about where to put it. I think you're right. I'll move it and add the !important
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.143 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the tokens-font file to be tokens-local since it evolved to include more than just font - e.g. the transition token override for turning off motion completely is added there in this PR.
Fixes #6516
Fixes #6682