fix(docs): promote various components/features out of beta#6759
Conversation
|
Preview: https://patternfly-pr-6759.surge.sh A11y report: https://patternfly-pr-6759-a11y.surge.sh |
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just to confirm:
- We're leaving drag/drop as beta? It's in the spreadsheet but it's a special color, so just wanted to double check that we're leaving it.
- Looks like the label group "add" example is no longer beta, but unless I missed it, I don't see it in the spreadsheet.
- nav item icons is no longer beta - I added that feature/beta label for v6 but not sure if it's necessary. The motivation to make that change is to the vertical nav's ability to collapse down to an icon-only view, so having nav icons as beta would allow us to make changes to that element we might not otherwise be able to, until the vertical nav feature is complete. But the icon element in nav is super simple, so it's probably not necessary. @andrew-ronaldson wdyt?
|
ah - yeah the Nav Link Text was on the spread sheet and from what I could tell, that seemed to be the same as Nav Item icons? I didn't look into it too long so if i removed the label erroneously, I can add it back 👍🏻 but we might need to double check that the appropriate react example is also marked beta? I don't think there is currently parity here, the react example is still called nav link text (i think). I think I assumed that the label group "add" example was all part of the same editable label group concept. Is it separate? Should it stay in beta? |
|
@nicolethoen gotcha! Some feedback below but tl;dr - the PR looks good, we shouldn't need a beta label for nav icons or add labels. "nav link text" was added as an opt-in last year (#5868) for when non-string text is used in a nav link, though it also is needed for the vertical-nav-collape-to-an-icon feature, so technically they're separate enhancements. That said, I brought this up in the working session and I don't think anyone (including me) think the nav item icon needs to be beta, it's really simple, and any "breaking" changes to the nav icon needed to support collapable-vertical-nav can likely happen behind a class (opt-in) either on the icon itself or behind the class on the nav/sidebar to collapse it. re: editable label, we added editable labels on 5/27/2021 and "add" label on 5/4/22, so technically they're separate. But we've had the add label for 2 years so and I brought it up in working session and no one anticipates needing to change it in a way that's breaking, so removing the beta label seems like a good move! |
|
@mcoker can we merge this? |
|
🎉 This PR is included in version 6.0.0-alpha.171 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Closes: #6749