fix(Wizard): updated styling for wizard body#6807
Conversation
|
Preview: https://patternfly-pr-6807.surge.sh A11y report: https://patternfly-pr-6807-a11y.surge.sh |
|
@srambach tl;dr this is to support the drawer placed as a child of |
| .#{$wizard}__main { | ||
| z-index: var(--#{$wizard}__main--ZIndex); | ||
| display: flex; | ||
| flex: 1 1 auto; |
There was a problem hiding this comment.
I think you'll want to remove this line as default flex values resolve to:
flex-grow: 0;
flex-shrink: 1;
flex-basis: auto;
And all you need to update is :last-child if that's an agreeable solution.
There was a problem hiding this comment.
At least for the flex property that should still be needed so that the wizard main element fills whatever space to match the current behavior when a drawer is rendered inside wizard main.
@mcoker can't recall what the discussion was, but was flex-grow on the :last-child necessary? Believe testing these styles in my React PR omitting the flex-grow on last child doesn't change anything (though i may just not be using the combo of elements to notice a difference)
thatblindgeye
force-pushed
the
wizardBodyStyling
branch
from
0dc2bd6 to
e13a322
Compare
|
🎉 This PR is included in version 6.0.0-alpha.171 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Closes #6809