fix(button): update buttons in workspace to include text/icon wrapper#6815
Conversation
|
Preview: https://patternfly-pr-6815.surge.sh A11y report: https://patternfly-pr-6815-a11y.surge.sh |
mcoker
force-pushed
the
issue-6808
branch
2 times, most recently
from
c881067 to
9cbcf08
Compare
Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
| {{#if button--id}} | ||
| id="{{button--id}}" | ||
| {{/if}} | ||
| {{ternary button--id button--id null}} |
There was a problem hiding this comment.
Sorry, I left out the string constructor part here
| {{ternary button--id button--id null}} | |
| {{ternary button--id (concat 'id="' button--id '"') null}} |
@mcoker That's part of updating interactive elements to Mobile 
Desktop 
|
|
This one moved the add link on a repeatable field from the middle to left - I think it's ok but it's different. pf-core__components_forms_form_html-demos_sections-with-repeatablefields_0_document_0_mobile.png Also the clear filters link here, same thing pf-core__components_toolbar_html-demos_toolbar-attribute-value-checkbox-menutoggle-filter-on-mobile_0_document_0_mobile.png If those are ok, I don't see any other issues with any of the other diffs and 👍 example of difference: |
mattnolting
left a comment
mattnolting
left a comment
There was a problem hiding this comment.
I tested in many different scenarios and it works quite well, good work 👍 LPTM!
|
🎉 This PR is included in version 6.0.0-alpha.175 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
fixes #6808
Backstop report -
backstop-buttons-6.24.24.pdf
@andrew-ronaldson @lboehling it's not necessarily tied to buttons, but I noticed the layout for chips/labels in the toolbar is different from v5. Is the v6 screenshot below what it should look like or do we need to make updates?
v5 - the chip groups and clear all filters button are inline with one another
v6 - everything is on its own line
