fix(vars): clean up references to old button spacers#6851
Conversation
| --#{$data-list}__item-action__action--MarginBlockStart: calc(var(--pf-t--global--spacer--sm) * -1); // former form-element | ||
| --#{$data-list}__action--MarginBlockStart: var(--#{$data-list}__item-action__action--MarginBlockStart); // update at breaking change | ||
| --#{$data-list}__item-action__action--MarginBlockEnd: calc(var(--pf-t--global--spacer--sm) * -1); // former form-element | ||
| --#{$data-list}__item-action__action--MarginBlockStart: calc(var(--pf-t--global--spacer--control--vertical--plain) * -1); | ||
| --#{$data-list}__item-action__action--MarginBlockEnd: calc(var(--pf-t--global--spacer--control--vertical--plain) * -1); |
There was a problem hiding this comment.
- Replaces
__actionvar with__item-action, was flagged to update in a breaking change in this PR/comment - fix(datalist-alignment): updated alignment settings #3750 (review) - Uses the vertical button/action/control/etc token
| margin-block-start: var(--#{$data-list}__action--MarginBlockStart); | ||
| margin-block-start: var(--#{$data-list}__item-action__action--MarginBlockEnd); |
There was a problem hiding this comment.
- Replaces
__actionvar with__item-action, was flagged to update in a breaking change in this PR/comment - fix(datalist-alignment): updated alignment settings #3750 (review)
There was a problem hiding this comment.
Should this be --MarginBlockStart?
There was a problem hiding this comment.
Oops! Updated and updated a > *:not(:last-child) inline margin to gap - 66af31d
|
Preview: https://patternfly-pr-6851.surge.sh A11y report: https://patternfly-pr-6851-a11y.surge.sh |
| --#{$table}--m-grid__check--favorite--MarginInlineStart: var(--pf-t--global--spacer--xl); | ||
|
|
||
| // * Table grid action | ||
| --#{$table}--m-grid__action--MarginBlockStart: #{pf-size-prem(6px)}; |
There was a problem hiding this comment.
This doesn't look necessary:
Before
After. The cell's top padding matches the button's, so no margin on the action wrapper aligns the button text with the cell text
| margin-block-start: var(--#{$table}--m-tree-view-grid__action--MarginBlockStart); | ||
| margin-block-end: var(--#{$table}--m-tree-view-grid__action--MarginBlockEnd); |
There was a problem hiding this comment.
This moves the margin to the actions container since anything can go in the __action cell (not just a menu-toggle or button). @mattnolting do you see any problem with the margin on __action? It also has a bunch of padding and stuff but aligns fine as far as I can tell.
| --#{$data-list}__action--MarginBlockStart: var(--#{$data-list}__item-action__action--MarginBlockStart); // update at breaking change | ||
| --#{$data-list}__item-action__action--MarginBlockEnd: calc(var(--pf-t--global--spacer--sm) * -1); // former form-element | ||
| --#{$data-list}__item-action__action--MarginBlockStart: calc(var(--pf-t--global--spacer--control--vertical--plain) * -1); | ||
| --#{$data-list}__item-action__action--MarginBlockEnd: calc(var(--pf-t--global--spacer--control--vertical--plain) * -1); |
There was a problem hiding this comment.
Looks like --#{$data-list}__action--MarginBlockStart is set in the compact variant on line 155 but never used.
There was a problem hiding this comment.
(I think you can remove line 155?)
| margin-block-start: var(--#{$data-list}__action--MarginBlockStart); | ||
| margin-block-start: var(--#{$data-list}__item-action__action--MarginBlockEnd); |
There was a problem hiding this comment.
Should this be --MarginBlockStart?
|
@srambach updated, changed the Backstop report reports no failures compared to the last backstop run - backstop-data-list-7.10.24.pdf Here's the commit - 71d74e2 |
|
🎉 This PR is included in version 6.0.0-alpha.196 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
fixes #6640