Skip to content

fix(notification-drawer): fix action alignment, add no-offset mod #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 1 commit into from
Jul 9, 2024
Merged

fix(notification-drawer): fix action alignment, add no-offset mod #6854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/patternfly/components/NotificationDrawer/examples/NotificationDrawer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,4 @@ cssPrefix: pf-v6-c-notification-drawer
| `.pf-m-hoverable` | `.pf-v6-c-notification-drawer__list-item` | Modifies a notification list item hover states to inidicate it is clickable. |
| `.pf-m-expanded` | `.pf-v6-c-notification-drawer__group` | Modifies a notification group for the expanded state. |
| `.pf-m-truncate` | `.pf-v6-c-notification-drawer__list-item-header-title` | Modifies the title to display a single line and truncate any overflow text with ellipses. **Note:** you can specify the max number of lines to show by setting the `--pf-v6-c-notification-drawer__list-item-header-title--max-lines` (the default value is `1`). |
| `.pf-m-no-offset` | `.pf-v6-c-notification-drawer__list-item-action` | Modifies a notification item action to remove the vertical offset for action alignment. |
19 changes: 19 additions & 0 deletions src/patternfly/components/NotificationDrawer/notification-drawer-basic-list.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,23 @@
50 minutes ago
{{/notification-drawer-list-item-timestamp}}
{{/notification-drawer-list-item}}
{{#> notification-drawer-list-item notification-drawer-list-item--IsSuccess="true" notification-drawer-list-item--IsRead="true"}}
{{#> notification-drawer-list-item-header}}
{{> notification-drawer-list-item-header-icon}}
{{#> notification-drawer-list-item-header-title}}
Notification drawer item title
{{/notification-drawer-list-item-header-title}}
{{/notification-drawer-list-item-header}}
{{#> notification-drawer-list-item-action notification-drawer-list-item-action--modifier="pf-m-no-offset"}}
{{#> button button--IsPrimary=true}}
Action
{{/button}}
{{/notification-drawer-list-item-action}}
{{#> notification-drawer-list-item-description}}
This example uses ".pf-m-no-offset" on the action wrapper to disable the default offset for button alignment.
{{/notification-drawer-list-item-description}}
{{#> notification-drawer-list-item-timestamp}}
55 minutes ago
{{/notification-drawer-list-item-timestamp}}
{{/notification-drawer-list-item}}
{{/notification-drawer-list}}
8 changes: 8 additions & 0 deletions src/patternfly/components/NotificationDrawer/notification-drawer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@
--#{$notification-drawer}__list-item-header-title--FontWeight: var(--pf-t--global--font--weight--body--bold);
--#{$notification-drawer}__list-item-header-title--max-lines: 1;

// List item action
--#{$notification-drawer}__list-item-action--MarginBlockStart: calc(var(--pf-t--global--spacer--control--vertical--plain) * -1);

// List item description
--#{$notification-drawer}__list-item-description--MarginBlockEnd: var(--pf-t--global--spacer--sm);

Expand Down Expand Up @@ -237,6 +240,11 @@
.#{$notification-drawer}__list-item-action {
grid-row: 1 / 3;
grid-column: 2 / 3;
margin-block-start: var(--#{$notification-drawer}__list-item-action--MarginBlockStart);

&.pf-m-no-offset {
--#{$notification-drawer}__list-item-action--MarginBlockStart: 0;
}
}

.#{$notification-drawer}__list-item-description {
Expand Down