Skip to content

chore(button): unescaped button--id attribute#6901

Merged
mcoker merged 2 commits into
patternfly:v6from
mcoker:issue-6887
Jul 19, 2024
Merged

chore(button): unescaped button--id attribute#6901
mcoker merged 2 commits into
patternfly:v6from
mcoker:issue-6887

Conversation

@mcoker

@mcoker mcoker commented Jul 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #6887

Here's the same button from the issue description after this PR

Screenshot 2024-07-17 at 12 16 13 PM

@mcoker mcoker requested review from mattnolting and srambach July 17, 2024 17:18
@patternfly-build

patternfly-build commented Jul 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://patternfly-pr-6901.surge.sh

A11y report: https://patternfly-pr-6901-a11y.surge.sh

@srambach

srambach commented Jul 18, 2024

Copy link
Copy Markdown
Member

Found the duplicate id - dashboard-demo-expandable-status-card-1-toggle on https://patternfly-pr-6901.surge.sh/patterns/dashboard/html-demos/basic/

The expansion caret:
<button class="pf-v6-c-button pf-m-plain" id="dashboard-demo-expandable-status-card-1-toggle" type="button" aria-labelledby="dashboard-demo-expandable-status-card-1-title dashboard-demo-expandable-status-card-1-toggle" aria-label="Details">

The kebab:
<button class="pf-v6-c-menu-toggle pf-m-plain" type="button" aria-expanded="false" aria-label="Menu toggle" id="dashboard-demo-expandable-status-card-1-toggle">

@mcoker

mcoker commented Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

@srambach thanks! fixed

mattnolting
mattnolting approved these changes Jul 19, 2024
View reviewed changes

@mattnolting mattnolting left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!! 🐱

@mcoker mcoker merged commit 7d07229 into patternfly:v6 Jul 19, 2024
@mcoker mcoker mentioned this pull request Jul 19, 2024
Closed
@patternfly-build

patternfly-build commented Jul 19, 2024

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.0.0-alpha.201 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker deleted the issue-6887 branch January 7, 2025 16:52
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

@srambach srambach Awaiting requested review from srambach

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcoker @patternfly-build @srambach @mattnolting