fix(menu-toggle): added support for placeholder, fixed disabled icon color#6963
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6963.surge.sh A11y report: https://patternfly-pr-6963-a11y.surge.sh |
thatblindgeye
left a comment
thatblindgeye
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Could we add an example showing the new modifier in use? Would be easier to compare/see the difference between it and a basic toggle
srambach
approved these changes
Aug 14, 2024
srambach
left a comment
srambach
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the new example. 🛤️
thatblindgeye
approved these changes
Aug 14, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.211 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6962
.pf-m-placeholderon the menu toggle, which changes the text color to the placeholder color tokeninherit(matched text color), so this wires up/fixes vars to use icon color tokensBackstop report has no failures other than this random one, which looks like a viewport size/timing glitch
BackstopJS Report.pdf