fix(toolbar): fix expanded content position in masthead#6986
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6986.surge.sh A11y report: https://patternfly-pr-6986-a11y.surge.sh |
srambach
approved these changes
Aug 20, 2024
srambach
left a comment
srambach
left a comment
Member
There was a problem hiding this comment.
After discussion - all good!
The example in question is a mobile expandable toolbar, and at desktop width the expanded content does not have padding around the toolbar. Currently there really isn't a core example showing a solution for this at desktop width, but there's really not a good use case for this. If it comes up, we can further consider how to handle the padding around expanded content at desktop width.
Contributor
Author
|
@srambach thanks for the meeting notes! |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.220 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6918
BackstopJS Report.pdf with
filter="toolbar|masthead"The 3 failures are the last 3 in the report, and seem to match the layout I see for these examples v5