feat(various): remove hardcoded namespace#7023
Merged
mcoker merged 2 commits intoAug 29, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7023.surge.sh A11y report: https://patternfly-pr-7023-a11y.surge.sh |
mcoker
requested changes
Aug 29, 2024
Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
mcoker
approved these changes
Aug 29, 2024
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Visual regression report
BackstopJS Report.pdf
Everything is either a known regression from a previous fix, something fixed in this PR, or just a false positive (looking at you, "pf-core__components_page_html_centered-section_0_document_2_desktop.png")
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.230 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6991
Removes remaining hardcoded
--pf-v6-instances and replaces them with the appropriate sass variable for the prefix.Visual regression tests for nav, sidebar, table, utilities, and text show the same number of failures (9, 5, 15, 0, and 5 respectively) as when I ran it before changes, and all are indistinguishable.