fix(menu-toggle): correct avatar alignment within menu-toggle #7416
Conversation
|
Preview: https://patternfly-pr-7416.surge.sh A11y report: https://patternfly-pr-7416-a11y.surge.sh |
sg00dwin
force-pushed
the
7317-menu-toggle-avatar-img
branch
from
2b977ae to
cbe70fe
Compare
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Looking good! Next we'll need to make sure this avatar (or any large icon) doesn't change the menu toggle height. I tried this and it seemed OK but I didn't text extensively. Also it breaks plain/icon-only toggles:
.pf-v6-c-menu-toggle__icon {
margin-block-start: calc(-1 * var(--pf-v6-c-menu-toggle--PaddingBlockStart));
margin-block-end: calc(-1 * var(--pf-v6-c-menu-toggle--PaddingBlockEnd));
}
sg00dwin
force-pushed
the
7317-menu-toggle-avatar-img
branch
from
cbe70fe to
e85a8ec
Compare
|
I think I'm seeing shift down of a couple pixels on the avatar menu toggle compared to the others, but I'm not sure why. |
I'm fine with merging and if it seems to really be a problem for consumers, we can put in a bug for the alignment. |
|
🎉 This PR is included in version 6.3.0-prerelease.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
fixes #7410
Aligns the menu-toggle icon
imgcorrectly. Also removedpf-m-avatarmodifier.