Skip to content

fix(card): remove padding/margin on clickable cards action element #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 3 commits into from
Oct 27, 2025
+8 −0
Merged

fix(card): remove padding/margin on clickable cards action element #7928

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff6161c
fix(card): remove padding/margin on clickable cards action element
wise-king-sullyman Oct 23, 2025
d9aaa56
fix(card): only remove padding on actionable only or hidden input cards
wise-king-sullyman Oct 24, 2025
fbe2de1
chore: update selector
mcoker Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/patternfly/components/Card/card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,14 @@
}
// stylelint-enable selector-max-class

// when the whole card is clickable and the card actions are invisible, remove the padding/margin so it doesn't take up space
@at-root .#{$card}__actions:has(> .#{$card}__selectable-actions input.#{$pf-prefix}screen-reader),

@srambach srambach Oct 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment would be maybe it's worth a comment here to explain what this selector is aiming to do since it's pretty obscure and really only in react.

&.pf-m-clickable:not(.pf-m-selectable) {
--#{$card}__actions--PaddingInlineStart: 0;
--#{$card}__actions--MarginBlockStart: 0;
--#{$card}__actions--MarginBlockEnd: 0;
}

&.pf-m-compact {
--#{$card}__title-text--FontSize: var(--#{$card}--m-compact__title-text--FontSize);
--#{$card}__body--FontSize: var(--#{$card}--m-compact__body--FontSize);
Expand Down