feat(icons): add icon set swapping support#8123
Merged
Merged
Conversation
Contributor
WalkthroughAdds SCSS rules that hide the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
For testing, I manually pulled an svg from the react PR with updated class names into the local build. Here's one I was using to showcase/test the classes that can be used in this PR preview: |
Collaborator
|
Preview: https://pf-pr-8123.surge.sh A11y report: https://pf-pr-8123-a11y.surge.sh |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/patternfly/base/patternfly-svg-icons.scss`:
- Around line 10-22: The CSS class names use underscores and a non-PatternFly
modifier style (.#{$pf-prefix}icon_rh-ui, .#{$pf-prefix}icons-set_rh-ui,
.#{$pf-prefix}icon_default) which deviates from PF BEM conventions; rename these
to hyphenated, PF modifier-style names (for example .#{$pf-prefix}icon-rh-ui ->
.#{$pf-prefix}icon--rh-ui or .#{$pf-prefix}icon.pf-m-rh-ui, and
.#{$pf-prefix}icons-set_rh-ui -> .#{$pf-prefix}icons-set.pf-m-rh-ui or
.#{$pf-prefix}icons-set--rh-ui, and .#{$pf-prefix}icon_default ->
.#{$pf-prefix}icon--default or .#{$pf-prefix}icon.pf-m-default) and update the
selectors in patternfly-svg-icons.scss (the rules around
.#{$pf-prefix}icon_rh-ui, .#{$pf-prefix}icons-set_rh-ui, and
.#{$pf-prefix}icon_default) accordingly; also search and replace all usages
across the codebase to keep HTML/JS references consistent and run the project's
stylelint/rg checks to ensure naming now matches existing PF patterns (pf-m or
pf-t) and no underscores remain.
- Around line 14-22: Replace the use of display: revert on the
.#{$pf-prefix}icon_rh-ui rule with an explicit display value to avoid unintended
overrides by future cascade rules; update the selector
.#{$pf-prefix}icons-set_rh-ui .#{$pf-prefix}icon_rh-ui to use display: inline
(or another explicit display appropriate for inner <svg> elements) instead of
revert so the nested SVGs render predictably regardless of later stylesheet
changes.
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.41 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 24, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8072.
Adds class for a default/PF icon (
pf-v6-icon-default), a RH-ui set icon (pf-v6-icon-rh-ui), and a class to control when RH-ui icons should be displayed instead of PF icons (pf-v6-icons-rh-ui).The svg for an icon that has a mapping between PF + RH icons will have a nested structure, with an outer svg containing most of the shared properties &
pf-v6-svg, and two inner svgs (one withpf-v6-icon-defaultand one withpf-v6-icon-rh-ui) that contain their respective path data and viewbox properties.Let me know what you think about these class names, I'm open to suggestions & not 100% on the preference between hyphens and underscores.
Summary by CodeRabbit