Skip to content

fix(modal): change 2 icons to new ones#8200

Merged
mcoker merged 1 commit into
patternfly:mainfrom
srambach:3136-modal-unified
Mar 9, 2026
Merged

fix(modal): change 2 icons to new ones#8200
mcoker merged 1 commit into
patternfly:mainfrom
srambach:3136-modal-unified

Conversation

@srambach

@srambach srambach commented Mar 4, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Fixes #8129

No change to the background token needed. Most icons were fixed in global PRs, and this cleans up the custom icon and help icon.

Summary by CodeRabbit

  • Style
    • Updated icons in ModalBox component headers and examples for improved visual consistency

@coderabbitai

coderabbitai Bot commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 575dc5b5-5e8a-4ae8-8ad3-9b7f281f1042

📥 Commits

Reviewing files that changed from the base of the PR and between d8cc066 and 684b524.

📒 Files selected for processing (2)
  • src/patternfly/components/ModalBox/examples/ModalBox.md
  • src/patternfly/components/ModalBox/modal-box-header-help.hbs

Walkthrough

Two files in the ModalBox component were updated to use Red Hat brand icons: the example documentation changed the title icon from bullhorn to rh-standard-megaphone, and the header help template changed from icon-help to rh-ui-question-mark-circle.

Changes

Cohort / File(s) Summary
ModalBox Icon Updates
src/patternfly/components/ModalBox/examples/ModalBox.md, src/patternfly/components/ModalBox/modal-box-header-help.hbs		 Replaced icon references with RH brand icons: bullhorn → rh-standard-megaphone in example; icon-help → rh-ui-question-mark-circle in header help template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

  • #8066: Updates modal component icon references to align with design system modernization.

Possibly related PRs

  • PR #8165: Updates template icon references from legacy icon-template usage to new rh-ui icon names across multiple components.
  • PR #8177: Corrects icon identifiers in Handlebars templates for various PatternFly components.
  • PR #8179: Modifies ModalBox icon usage to use rh-* icon references for consistency.

Suggested labels

released on @prerelease``

Suggested reviewers

  • andrew-ronaldson
  • kmcfaul
  • mcoker
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format (type: description) and clearly describes the main change of updating two modal icons.
Linked Issues check ✅ Passed The PR successfully updates two modal icons to new RH brand icons as required by issue #8129, addressing the main objective of the linked issue.
Out of Scope Changes check ✅ Passed All changes are directly related to updating modal icons to RH brand icons as specified in issue #8129; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8200.surge.sh

A11y report: https://pf-pr-8200-a11y.surge.sh

@mcoker mcoker merged commit 23cb693 into patternfly:main Mar 9, 2026
5 checks passed
@patternfly-build

patternfly-build commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.51 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 16, 2026
Open
Closed
Closed
This was referenced Mar 27, 2026
Open
Open
This was referenced Apr 2, 2026
Open
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@mcoker mcoker mcoker approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees

No one assigned

Labels

Needs react follow up released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modal - update to RH brand icons & unified tokens

5 participants

@srambach @patternfly-build @andrew-ronaldson @mcoker @lboehling