Skip to content

fix(CodeEditor): make plain header background transparent#8265

Merged
mcoker merged 1 commit into
patternfly:mainfrom
kmcfaul:plain-fix
Mar 30, 2026
Merged

fix(CodeEditor): make plain header background transparent#8265
mcoker merged 1 commit into
patternfly:mainfrom
kmcfaul:plain-fix

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Mar 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Closes #8107

Fixes CodeEditorHeader's plain modifier to make the background transparent (specifically, for our docs in glass theme where every example uses a plain CodeEditorHeader).

Summary by CodeRabbit

  • Style
    • Updated the Code Editor component's plain-mode header to display with a transparent background instead of the default primary color background.

@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8a7e4dff-ea17-4852-8596-fcf71ca065aa

📥 Commits

Reviewing files that changed from the base of the PR and between 6866c68 and d2c2b6a.

📒 Files selected for processing (1)
  • src/patternfly/components/CodeEditor/code-editor.scss

Walkthrough

A single CSS variable in the CodeEditor component was updated to change the plain header modifier background from PatternFly's primary background color to transparent, addressing the bug where plain headers incorrectly retained a background color.

Changes

Cohort / File(s) Summary
CodeEditor Styling
src/patternfly/components/CodeEditor/code-editor.scss		 Changed --#{$code-editor}__header-content--m-plain--BackgroundColor from primary background color to transparent to fix plain header styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

released on @prerelease``

Suggested reviewers

  • mcoker
  • srambach
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with 'fix' type prefix and clearly describes the main change of making the plain header background transparent.
Linked Issues check ✅ Passed The code change directly addresses issue #8107 by updating the plain modifier to use a transparent background instead of the primary background color.
Out of Scope Changes check ✅ Passed All changes are within scope, modifying only the CodeEditor component's plain header background color to meet the stated objective of issue #8107.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8265.surge.sh

A11y report: https://pf-pr-8265-a11y.surge.sh

@mcoker mcoker merged commit 29c6326 into patternfly:main Mar 30, 2026
5 checks passed
@patternfly-build

patternfly-build commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.62 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Apr 14, 2026
Open
@coderabbitai coderabbitai Bot mentioned this pull request May 8, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - CodeEditor - plain header styling still applies a background color

3 participants

@kmcfaul @patternfly-build @mcoker