Skip to content

feat(misc): rename redhat to felt#8354

Merged
mcoker merged 8 commits into
patternfly:mainfrom
kmcfaul:felt-rename
May 6, 2026
Merged

feat(misc): rename redhat to felt#8354
mcoker merged 8 commits into
patternfly:mainfrom
kmcfaul:felt-rename

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Closes #8346

Needs patternfly/design-tokens#144 to go in first to update the file names

Summary by CodeRabbit

  • Style
    • Updated application styling to use the Felt design theme with support for all theme variants (default, high-contrast, glass, and dark modes).

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6025f2e7-8133-4453-aa67-c4b81377f5b7

📥 Commits

Reviewing files that changed from the base of the PR and between 51bf4cc and 9d02597.

📒 Files selected for processing (2)
  • backstop_data/engine_scripts/playwright/onBefore.js
  • src/patternfly/base/patternfly-variables.scss

Walkthrough

These changes replace "redhat" theme references with "felt" theme references across the initialization logic and theme variable configuration, updating both Playwright test setup and theme token definitions.

Changes

Cohort / File(s) Summary
Theme initialization
backstop_data/engine_scripts/playwright/onBefore.js
Updated theme variant assignment from 'theme-redhat' to 'theme-felt' when the --felt flag is detected.
Theme token configuration
src/patternfly/base/patternfly-variables.scss
Replaced all pf-v6-theme-redhat token module imports and corresponding theme selector rules with pf-v6-theme-felt, including variants for default, high-contrast, glass, and dark themes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit guidelines with 'feat(misc)' prefix and clearly describes the main change: renaming redhat theme to felt.
Linked Issues check ✅ Passed The PR successfully addresses the primary objective from #8346 by updating theme references from 'redhat' to 'felt' in patternfly-variables.scss and onBefore.js scripts.
Out of Scope Changes check ✅ Passed All changes are scoped to updating 'redhat' theme references to 'felt' theme across specified files; no extraneous changes detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 6/8 reviews remaining, refill in 9 minutes and 24 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

@mcoker mcoker self-requested a review May 5, 2026 04:00

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified there are zero errors across all themes in visual regressions.

@mcoker mcoker requested a review from thatblindgeye May 5, 2026 14:46

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm especially after the updates in patternfly.scss to lines 23, 29, 47, and 51

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that ^ we probably need to bump the docs framework too

@mcoker mcoker merged commit a9965f9 into patternfly:main May 6, 2026
5 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.84 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update "redhat" theme to "project felt"

4 participants