feat(Toolbar): Add row wrap prop to ToolbarGroup and ToolbarItem#11559
Conversation
|
Preview: https://patternfly-react-pr-11559.surge.sh A11y report: https://patternfly-react-pr-11559-a11y.surge.sh |
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just a couple of things:
- we don't support
.pf-m-wrap-reverse .pf-m-wrapand.pf-m-nowrapapplies to.pf-v6-c-toolbar__content-section, too - https://github.com/patternfly/patternfly/blob/93efaf133c72a9e1944660bd404ad8b38f850d93/src/patternfly/components/Toolbar/toolbar.scss#L360-L369
There was a problem hiding this comment.
In addition to adding the prop to ToolbarContent (for the ContentSection class), could we add a simple example for that? Maybe we could update the section from "Examples with toolbar spacers" to "Examples with spacers and wrapping", then add a "Toolbar content wrapping" example to show the nowrap modifier in use (the example description could mention that by default the content section wraps).
Also can we add quick unit tests for these components for the new modifier as well
mfrances17
force-pushed
the
wrap-tbgroup
branch
from
8f065d0 to
b1bd21d
Compare
|
thanks @mcoker & @thatblindgeye, i've added a wrap prop to |
tlabaj
left a comment
tlabaj
left a comment
There was a problem hiding this comment.
Looks good. Just one ask.
mfrances17
force-pushed
the
wrap-tbgroup
branch
from
b1bd21d to
6560ed6
Compare
mfrances17
force-pushed
the
wrap-tbgroup
branch
from
6560ed6 to
b7ab4f3
Compare
mfrances17
force-pushed
the
wrap-tbgroup
branch
from
b7ab4f3 to
994fe51
Compare
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
6 participants
What: Closes #11489