chore(Hint): react testing library test revamps#7626
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7626.surge.sh A11y report: https://patternfly-react-pr-7626-a11y.surge.sh |
wise-king-sullyman
requested changes
Jul 5, 2022
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
Collaborator
There was a problem hiding this comment.
This is looking great! I just have a handful of small requests.
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
Collaborator
There was a problem hiding this comment.
I have one tiny nit about a test name, but other than that this is looking really solid!
wise-king-sullyman
approved these changes
Jul 8, 2022
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
Collaborator
There was a problem hiding this comment.
🚀 🚀 🚀 awesome work on this!
nicolethoen
approved these changes
Jul 11, 2022
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jul 26, 2022
* chore(Hint): react testing library test revamps * chore(Hint): added tests for testing actions options * chore(Hint): added action prop and inherited prop tests * chore(Form): quick test name change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #7616 . Added new tests for the Hint component (and subcomponents).
Additional issues: