fix(clipboard-copy): added rtl support#9629
Merged
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9629.surge.sh A11y report: https://patternfly-react-pr-9629-a11y.surge.sh |
mcoker
requested review from
mfrances17,
thatblindgeye,
tlabaj and
wise-king-sullyman
thatblindgeye
requested changes
Sep 15, 2023
thatblindgeye
left a comment
thatblindgeye
left a comment
Contributor
There was a problem hiding this comment.
As part of this, we should update the Toggle icon to mirror in RTL. When collapsed, the caret icon should be facing towards the text input.
LTR:
RTL:
| value={this.state.text as string | number} | ||
| id={`text-input-${id}`} | ||
| aria-label={textAriaLabel} | ||
| dir={isCode && 'ltr'} |
Contributor
There was a problem hiding this comment.
Nit: a lot of places we'll spread an object for a case like this:
Suggested change
| dir={isCode && 'ltr'} | |
| {...(isCode && { dir: 'ltr' })} |
Both ways result in the same result, though, with the dir attribute not being applied at all if isCode isn't true, so not a blocker.
thatblindgeye
approved these changes
Sep 15, 2023
Contributor
|
Just needs snapshots updated but otherwise looks good |
wise-king-sullyman
approved these changes
Sep 18, 2023
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9630
This makes the
isCodevariation retaindir="ltr"on the toggle text input and expanded content box.Verified with an RTL speaker that it looks as expected, as well as these examples all look correct and copy/paste the values correctly.
Inline compact
Code
Regular/expanded
Array/expanded