Updating for Android compatibility#28
Merged
Merged
Conversation
noelherrick
force-pushed
the
android-compat
branch
from
fd4b37a to
d7710ac
Compare
Collaborator
Author
|
@jnankin This is ready for your review! |
jnankin
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrade deals with Android compatibility: not only are there different Java APIs available, the implementations are incompatible and have different behavior. Specifically, the HTTP connection must be read entirely before closing. Reading after a call to close causes an error, since on Android, there's a different implementation that doesn't expect you to read the connection after closing.