Skip to content

test cases inherit from PhpUnit testcase with namespeces#105

Merged
corpsee merged 1 commit into
php-censor:masterfrom
SimonHeimberg:testCaseBaseClass
Jul 24, 2017
Merged

test cases inherit from PhpUnit testcase with namespeces#105
corpsee merged 1 commit into
php-censor:masterfrom
SimonHeimberg:testCaseBaseClass

Conversation

@SimonHeimberg

Copy link
Copy Markdown
Contributor

Necessary to be runnable with phpunit 6

This name is available since phpunit 4.8.36 and 5.4.3.
@corpsee

corpsee commented Jul 24, 2017

Copy link
Copy Markdown
Member

See #102. I already test PHPUnit v6. I cann't merge it because PHPUnit v6 needs PHP v7+, but PHP Censor needs PHP v5.6+.

@corpsee corpsee closed this Jul 24, 2017
@corpsee

corpsee commented Jul 24, 2017

Copy link
Copy Markdown
Member

I was not right. It will work on PHP 5.6. Thanks @SimonHeimberg!

@corpsee corpsee reopened this Jul 24, 2017
@corpsee corpsee merged commit 7a8ed48 into php-censor:master Jul 24, 2017
@SimonHeimberg SimonHeimberg deleted the testCaseBaseClass branch August 18, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants