Added command to schedule tasks if not ran for a specified X days#126
Merged
Conversation
corpsee
reviewed
Oct 5, 2017
| /** @var Project $project */ | ||
| foreach ($projects as $project) { | ||
|
|
||
| $latestBuild = $this->buildStore->getByProjectId($project->getId(), 1); |
Member
There was a problem hiding this comment.
You should use getLatestBuilds instead of getByProjectId. Because getLatestBuilds has sorting by id. Postgres doen`t guarantee order of records if no ORDER BY.
Contributor
Author
|
Feedback has been applied |
Member
|
Thanks @Vincentv92! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
bash php bin/console php-censor:schedule-build 1Will check if there are upcoming builds and if there are not, or they are currently not running or pending will schedule a build.
This applies to every project