Split dashboard into widgets. Add build errors widget.#131
Merged
Conversation
Member
|
It is very impression feature 😍! Thank you @ss-gxp! I will try to review and test this request today+tomorrow. |
corpsee
reviewed
Nov 7, 2017
Member
There was a problem hiding this comment.
I guess it would be 'last_builds'?
ss-gxp
force-pushed
the
dashboard-widgets
branch
from
95222dc to
e29e6c7
Compare
corpsee
reviewed
Nov 7, 2017
Member
There was a problem hiding this comment.
We need to filter archived projects somewhere here. Like in WidgetAllProjectsController.php (Line 107).
Member
Author
There was a problem hiding this comment.
Filter added (at contoller level, not store level, to avoid join)
Member
There was a problem hiding this comment.
Thank you, controller level is ok.
ss-gxp
force-pushed
the
dashboard-widgets
branch
from
e29e6c7 to
11f58d7
Compare
Member
|
Dashboard visualy empty on my isntallation Uncaught TypeError: Cannot set property 'allProjects' of undefined
at all_projects.js:1
(anonymous) @ all_projects.js:1
last_builds.js:1 Uncaught TypeError: Cannot set property 'lastBuilds' of undefined
at last_builds.js:1
(anonymous) @ last_builds.js:1 |
Member
Member
Author
|
I think this browser cache. Try Ctrl-F5 |
Member
|
CTRL+F5 solve the problem ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.