Skip to content

Add deploy stage#34

Merged
corpsee merged 1 commit into
php-censor:masterfrom
ss-gxp:deploy-stage
Mar 16, 2017
Merged

Add deploy stage#34
corpsee merged 1 commit into
php-censor:masterfrom
ss-gxp:deploy-stage

Conversation

@ss-gxp

@ss-gxp ss-gxp commented Mar 16, 2017

Copy link
Copy Markdown
Member

Added separate stage for deploy

@corpsee

corpsee commented Mar 16, 2017

Copy link
Copy Markdown
Member

Hi, thank you for the request!

Now you can deploy in success stage. Why you want to add deploy stage? Can you give a real case for separate stage deploy?

@ketchoop

ketchoop commented Mar 16, 2017

Copy link
Copy Markdown
Contributor

@corpsee I think it's really good idea. In my case, I can't see, when deploy failed, but build is green and it's really annoying. And from point of semantic deployment is not test stage.

inb4: Of course we can use success stage for it, but, you know

I can't see, when deploy failed, but build is green

@corpsee

corpsee commented Mar 16, 2017

Copy link
Copy Markdown
Member

Ok, thanks.

@corpsee corpsee merged commit 788aeb1 into php-censor:master Mar 16, 2017
@ss-gxp ss-gxp deleted the deploy-stage branch March 16, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants