Skip to content

Add write cache to build log (improve speed)#45

Merged
corpsee merged 0 commit into
php-censor:masterfrom
ss-gxp:build-log-write-cache
Mar 30, 2017
Merged

Add write cache to build log (improve speed)#45
corpsee merged 0 commit into
php-censor:masterfrom
ss-gxp:build-log-write-cache

Conversation

@ss-gxp

@ss-gxp ss-gxp commented Mar 30, 2017

Copy link
Copy Markdown
Member

Current logging very slow оn thousands of lines.

@corpsee

corpsee commented Mar 30, 2017

Copy link
Copy Markdown
Member

Thanks!

@corpsee corpsee merged this pull request into php-censor:master Mar 30, 2017
@corpsee

corpsee commented Mar 30, 2017

Copy link
Copy Markdown
Member

@ss-gxp It doesn't work correct. Build log is not fully save( I reverted changes from master branch

@ss-gxp

ss-gxp commented Mar 30, 2017

Copy link
Copy Markdown
Member Author

Are there any details?
The problem does not appear in my case.
We can assume that saving in the destructor does not work, but not in my case. I'm using crontab to start builds. Since Beanstalkd did not check, this is not your case? Perhaps need forced flush when build done.

(Also I can say that about 22 thousand lines of the log were written about two and a half hours. With a patch in one second.)

@ss-gxp

ss-gxp commented Mar 30, 2017

Copy link
Copy Markdown
Member Author

Added unset log handler to destruct and flush data.
Can you test?

@corpsee

corpsee commented Mar 31, 2017

Copy link
Copy Markdown
Member

Yes, I use worker. I will check it tonight. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants