Show constant type alongside value in TOC and truncate long values#4108
Merged
jaapio merged 3 commits intoApr 17, 2026
Merged
Conversation
lacatoire
force-pushed
the
fix/toc-constant-show-type-and-truncated-value
branch
from
41887ea to
0652e36
Compare
jaapio
requested changes
Apr 15, 2026
jaapio
left a comment
jaapio
left a comment
Member
There was a problem hiding this comment.
I think it's better to move the truncation of this value into a filter in the twig extension. This allows other templates to reuse the same logic.
The current line is hard to interpret, a filter with the option to set the max length is easier to understand for users.
Member
|
I didn't know this exists when I added my first comment. But we can use this twig filter: https://twig.symfony.com/doc/3.x/filters/u.html |
Delegate constant value normalization and truncation in the TOC to the twig/string-extra u filter backed by Symfony/String, removing the custom truncate Twig filter.
jaapio
approved these changes
Apr 17, 2026
Member
|
Thanks for adjusting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2443