Skip to content

[Security] Add allowed_classes => false to unserialize() to prevent PHP Object Injection #6964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XananasX7 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

[Security] Add allowed_classes => false to unserialize() to prevent PHP Object Injection #6964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpBB/includes/functions_display.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ function get_forum_parents(&$forum_data)
}
else
{
$forum_parents = unserialize($forum_data['forum_parents']);
$forum_parents = unserialize($forum_data['forum_parents'], ['allowed_classes' => false]);
}
}

Expand Down
6 changes: 3 additions & 3 deletions phpBB/phpbb/extension/manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public function enable_step($name)
return false;
}

$old_state = (isset($this->extensions[$name]['ext_state'])) ? unserialize($this->extensions[$name]['ext_state']) : false;
$old_state = (isset($this->extensions[$name]['ext_state'])) ? unserialize($this->extensions[$name]['ext_state'], ['allowed_classes' => false]) : false;

$extension = $this->get_extension($name);

Expand Down Expand Up @@ -278,7 +278,7 @@ public function disable_step($name)
return false;
}

$old_state = unserialize($this->extensions[$name]['ext_state']);
$old_state = unserialize($this->extensions[$name]['ext_state'], ['allowed_classes' => false]);

$extension = $this->get_extension($name);
$state = $extension->disable_step($old_state);
Expand Down Expand Up @@ -330,7 +330,7 @@ public function purge_step($name)
$this->disable($name);
}

$old_state = unserialize($this->extensions[$name]['ext_state']);
$old_state = unserialize($this->extensions[$name]['ext_state'], ['allowed_classes' => false]);

$extension = $this->get_extension($name);
$state = $extension->purge_step($old_state);
Expand Down
2 changes: 1 addition & 1 deletion phpBB/phpbb/notification/type/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public function set_initial_data($data = array())
{
// The row from the database (unless this is a new notification we're going to add)
$this->data = $data;
$this->data['notification_data'] = !empty($this->data['notification_data']) ? unserialize($this->data['notification_data']) : [];
$this->data['notification_data'] = !empty($this->data['notification_data']) ? unserialize($this->data['notification_data'], ['allowed_classes' => false]) : [];
}

/**
Expand Down
2 changes: 1 addition & 1 deletion phpBB/phpbb/textreparser/manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function get_resume_data($name)
if ($this->resume_data === null)
{
$resume_data = $this->config_text->get('reparser_resume');
$this->resume_data = !empty($resume_data) ? unserialize($resume_data) : array();
$this->resume_data = !empty($resume_data) ? unserialize($resume_data, ['allowed_classes' => false]) : array();
}

return isset($this->resume_data[$name]) ? $this->resume_data[$name] : array();
Expand Down