Skip to content

azure.storage.getFiles: Support paging marker & limit #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osher wants to merge 8 commits into
base: master
Choose a base branch
from
Open

azure.storage.getFiles: Support paging marker & limit #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24413c4
azure - update TARGET_STORAGE_VERSION
osher Aug 7, 2018
4df4bb8
azure.storage.getFiles: Support paging marker & limit
osher Aug 8, 2018
701da75
petty lindt :P
osher Aug 8, 2018
f2228b3
lindt again? :P
osher Aug 8, 2018
c4cb5b9
es6/5 compat??
osher Aug 8, 2018
c0a4c5f
Merge branch 'master' into patch-1
osher Dec 3, 2018
199178c
Merge branch 'master' into patch-2
osher Dec 3, 2018
8b48fa4
Merge remote-tracking branch 'origin/patch-1' into patch-2
osher Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions lib/pkgcloud/azure/storage/client/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,25 +329,37 @@ exports.getFiles = function (container, options, callback) {
options = {};
}

const qs = {
restype: 'container',
comp: 'list'
};

if (options.limit) {
qs.maxresults = options.limit;
}
if (options.marker) {
qs.marker = options.marker;
}
if (options.prefix) {
qs.prefix = options.prefix;
}

this._xmlRequest({
method: 'GET',
path: containerName,
qs: {
restype: 'container',
comp: 'list'
}
qs: qs
}, function (err, body) {
if (err) {
return callback(err);
}
if (body.Blobs && body.Blobs.Blob) {
return callback(null, self._toArray(body.Blobs.Blob).map(function (file) {

callback(null,
body.Blobs && body.Blobs.Blob && self._toArray(body.Blobs.Blob)
.map(function (file) {
file.container = container;
return new storage.File(self, file);
}));
}

callback(null, []);
}) || [],
'string' == typeof body.NextMarker && body.NextMarker
);
});
};

4 changes: 2 additions & 2 deletions lib/pkgcloud/azure/utils/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2045,7 +2045,7 @@ var Constants = {
* @const
* @type {string}
*/
TARGET_STORAGE_VERSION: '2011-08-18',
TARGET_STORAGE_VERSION: '2014-02-14',

/**
* The UserAgent header.
Expand Down Expand Up @@ -2559,4 +2559,4 @@ var Constants = {
}
};

module.exports = Constants;
module.exports = Constants;