Skip to content

[3.0.x] Fix Microbenchmark tests to make it work with upcoming Scala releases (backport #13025) by @mkurz #13027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Dec 20, 2024
Merged

[3.0.x] Fix Microbenchmark tests to make it work with upcoming Scala releases (backport #13025) by @mkurz #13027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions core/play-microbenchmark/src/test/scala/play/core/server/netty/NettyHelpers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,23 @@ object NettyHelpers {
override def remoteAddress: SocketAddress = ra
// Stubs
override def doDisconnect(): Unit = ???
override def newUnsafe(): AbstractChannel#AbstractUnsafe = new AbstractUnsafe {
override def connect(remoteAddress: SocketAddress, localAddress: SocketAddress, promise: ChannelPromise): Unit =
???
}
override def isCompatible(loop: EventLoop): Boolean = ???
override def localAddress0(): SocketAddress = ???
override def doWrite(in: ChannelOutboundBuffer): Unit = ???
override def remoteAddress0(): SocketAddress = ???
override def doClose(): Unit = ???
override def doBind(localAddress: SocketAddress): Unit = ???
override def doBeginRead(): Unit = ???
override def config(): ChannelConfig = ???
override def metadata(): ChannelMetadata = ???
override def isActive: Boolean = ???
override def isOpen: Boolean = ???
// We can not access AbstractChannel#AbstractUnsafe, so we can not create a dummy class easily.
// I mean we could put such a class into the io.netty.channel package:
// package io.netty.channel
// class NonAbstractChannel extends AbstractChannel#AbstractUnsafe { override def connect(...) ... }
// However, returning null here works as well for now ;)
override def newUnsafe(): AbstractChannel#AbstractUnsafe = null
override def isCompatible(loop: EventLoop): Boolean = ???
override def localAddress0(): SocketAddress = ???
override def doWrite(in: ChannelOutboundBuffer): Unit = ???
override def remoteAddress0(): SocketAddress = ???
override def doClose(): Unit = ???
override def doBind(localAddress: SocketAddress): Unit = ???
override def doBeginRead(): Unit = ???
override def config(): ChannelConfig = ???
override def metadata(): ChannelMetadata = ???
override def isActive: Boolean = ???
override def isOpen: Boolean = ???
}
if (ssl) {
c.pipeline().addLast("ssl", new SslHandler(sslEngine))
Expand Down