Skip to content

Explicitly submit the root project's dependency#13145

Merged
mkurz merged 1 commit into
playframework:mainfrom
mkurz:explicitly_submit_root_project_deps
Feb 23, 2025
Merged

Explicitly submit the root project's dependency#13145
mkurz merged 1 commit into
playframework:mainfrom
mkurz:explicitly_submit_root_project_deps

Conversation

@mkurz

@mkurz mkurz commented Feb 23, 2025

Copy link
Copy Markdown
Member

I think it's confusing that all the alerts look like they come from the documentation project, which is not true. The documentation projects depends on the root project. By checking the root project explicitly, we should also see the alerts for build.sbt.

I just want to make sure that no one mistakenly thinks "oh ok it's just the docs, we are fine".

image

@mkurz mkurz merged commit b7be67e into playframework:main Feb 23, 2025
@mkurz mkurz deleted the explicitly_submit_root_project_deps branch February 23, 2025 15:00
@mkurz

mkurz commented Feb 23, 2025

Copy link
Copy Markdown
Member Author

@Mergifyio backport 2.9.x 3.0.x

@mergify

mergify Bot commented Feb 23, 2025

Copy link
Copy Markdown
Contributor

backport 2.9.x 3.0.x

✅ Backports have been created

Details

mkurz added a commit that referenced this pull request Feb 23, 2025
[2.9.x] Explicitly submit the root project's dependency (backport #13145) by @mkurz
mkurz added a commit that referenced this pull request Feb 23, 2025
[3.0.x] Explicitly submit the root project's dependency (backport #13145) by @mkurz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant