Fix: enforce subtree depth limit for tree cascade children#33
Merged
Conversation
AdrienClairembault
requested review from
Lainow
and removed request for
AdrienClairembault
stonebuzz
requested changes
Jul 1, 2026
| @@ -502,6 +504,53 @@ public function testDropdownShowsNameNotCompletename(): void | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The new test only exercises the children query path (verifying Level3 is excluded once depth is exceeded). It never exercises the parent_is_selectable path, which is fed by the same $condition_param that this fix restores. Can you add a test case where the controller is invoked with parent_id set to an item whose own level already exceeds subtree_depth (e.g. level3), and assert the response no longer renders the selectable placeholder (value="0") that parent_is_selectable controls in the twig template?
stonebuzz
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
The
TreeDropdownChildrenControllerwas stripping thelevel <= Ncondition from the WHERE clause before querying child items, causing the subtree depth limit configured on a Tree Cascade Dropdown question to be silently ignored.Removing the
unsetrestores the restriction so that AJAX child loading respects the configured depth.Screenshots (if appropriate):