(#8) - Remove a result XML file if a source file no longer exist#74
(#8) - Remove a result XML file if a source file no longer exist#74pollyvolk wants to merge 5 commits into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 53.96% 54.30% +0.34%
- Complexity 32 34 +2
============================================
Files 8 8
Lines 265 267 +2
Branches 24 25 +1
============================================
+ Hits 143 145 +2
+ Misses 119 118 -1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mximp Please, review |
|
@pollyvolk please always place reference to an issue within PR's description. |
| final String name = parts[1]; | ||
| final Path xml = this.temp.resolve(String.format("%s.xml", name)); | ||
| final Path src = this.sources.resolve(String.format("%s.eo", name)); | ||
| final Path xml = this.temp.resolve(String.format("%s.xml", name)).toAbsolutePath(); |
There was a problem hiding this comment.
@pollyvolk what caused the path to be changed to absolute? Were there issues with previous version of the code?
There was a problem hiding this comment.
@mximp You are right, this change is redundant, I will remove it
|
@yegor256 please merge |
3 participants
#8
How it was:
A user runs Polystat with
--files sources --tmp result, and there is a filesources/test.eo. The result of the analysis will be saved toresult/test.xml. If the user renames or deletes the filesources/test.eoand runs the same command again, Polystat will print the previous correct result, taking it fromresult/test.xml, not throwing an exception.After changes:
In the same case Polystat will throw a
FileNotFoundException.It throws an exception several times for each running
Analysis.