This repository was archived by the owner on Oct 28, 2019. It is now read-only.
Remove RepositoryPublishURLSerializer#93
Merged
Conversation
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
asmacdo
added a commit
to asmacdo/pulp_python
that referenced
this pull request
Apr 26, 2019
RequiredPR: pulp/pulpcore-plugin#93 RequiredPR: pulp/pulpcore#103 https://pulp.plan.io/issues/4699 fixes #4699
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 26, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 26, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 26, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 26, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
ref #4678 Required PR: pulp/pulpcore#103 Required PR: pulp/pulp_file#207
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 42.87% 42.27% -0.61%
==========================================
Files 22 21 -1
Lines 723 712 -11
==========================================
- Hits 310 301 -9
+ Misses 413 411 -2
Continue to review full report at Codecov.
|
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 26, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-openapi-generator#3
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 26, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 26, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 Required PR: pulp/pulp-openapi-generator#3 ref pulp#4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 27, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
Member
|
Removing this makes sense to me, but to confirm it's because the |
Contributor
Author
|
@bmbouter you're exactly correct. |
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
asmacdo
added a commit
to asmacdo/pulp_python
that referenced
this pull request
Apr 29, 2019
RequiredPR: pulp/pulpcore-plugin#93 RequiredPR: pulp/pulpcore#103 https://pulp.plan.io/issues/4699 fixes #4699
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp_rpm
that referenced
this pull request
Apr 29, 2019
Also remove publishers for now since they aren't being used currently. fixes #4739 https://pulp.plan.io/issues/4739 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to pulp/pulp-certguard
that referenced
this pull request
Apr 29, 2019
ref #4720 https://pulp.plan.io/issues/4720 Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files Required PR: pulp/pulp_file#207
daviddavis
pushed a commit
to daviddavis/pulpcore
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: pulp/pulp_file#207 Required PR: pulp/pulp-certguard#19 ref pulp#4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to pulp/pulp_file
that referenced
this pull request
Apr 29, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
May 14, 2019
Required PR: pulp/pulpcore-plugin#93 Required PR: https://github.com/pulp/pulpcore/pull/103/files ref #4678 https://pulp.plan.io/issues/4678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #4678
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/en/3.0/nightly/contributing/pull-request-walkthrough.html