Skip to content

(SERVER-2758) Update jruby to 9.2.11.0#87

Merged
justinstoller merged 2 commits into
puppetlabs:masterfrom
Magisus:jruby-9.2.11
Mar 23, 2020
Merged

(SERVER-2758) Update jruby to 9.2.11.0#87
justinstoller merged 2 commits into
puppetlabs:masterfrom
Magisus:jruby-9.2.11

Conversation

@Magisus

@Magisus Magisus commented Mar 19, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@Magisus Magisus requested a review from a team March 19, 2020 20:48
@Magisus

Magisus commented Mar 19, 2020

Copy link
Copy Markdown
Contributor Author

Getting test failures locally around loading openssl, want to see what happens in Travis.

@Magisus

Magisus commented Mar 20, 2020

Copy link
Copy Markdown
Contributor Author

So this failure seems to only occur in our testing environment. Other places that work fine:

  1. require 'openssl' in JRuby's irb
  2. jruby -S gem list
  3. puppetserver gem list

The error first shows up in 9.2.10.0, which is where they upgraded jruby-openssl from 0.10.2 to 0.10.4. This is also the release that updates RubyGems to 3+. Not sure if that could be related, since it's the gem list command that's struggling?

@Magisus

Magisus commented Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

@justinstoller thoughts on this error? (I'm currently working on adding logging to get more info on where the error is coming from, but having trouble with my dev build for this version.)

Or on the idea of ignoring it for the time being in favor of doing more comprehensive higher-level testing?

@justinstoller

Copy link
Copy Markdown
Member

[org.bouncycastle/bcpkix-jdk15on] needs to be added to the dev dependencies (sorry took me a while to track that one down). We must have missed this repo when doing our FIPS work.

@Magisus

Magisus commented Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

Ooh, great, I'll try that, thanks!

@mwaggett

Copy link
Copy Markdown
Contributor

Should we bump the Y version of jruby-utils for this change? Updating the jruby version seems bigger than a Z? ¯_(ツ)_/¯

@Magisus

Magisus commented Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

Sure.

@justinstoller justinstoller merged commit 4938a51 into puppetlabs:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants