Skip to content

Add crash and crashWith#2

Merged
paf31 merged 1 commit into
masterfrom
crash
Dec 18, 2015
Merged

Add crash and crashWith#2
paf31 merged 1 commit into
masterfrom
crash

Conversation

@paf31

@paf31 paf31 commented Dec 18, 2015

Copy link
Copy Markdown
Contributor

I figured these might make useful alternatives to the usual exhaustivity error message.

@garyb

garyb commented Dec 18, 2015

Copy link
Copy Markdown
Member

Good thinking 👍

@garyb

garyb commented Dec 18, 2015

Copy link
Copy Markdown
Member

Maybe we want unsafe versions of these too, without the constraint? So we can replace the unsafeThrow things we have in places currently where we're manually verifying something is not partial? I guess unsafePartial does the same job, but having another option for defining "it's-not-partial-honest" functions with a better fail error might be useful.

@paf31

paf31 commented Dec 18, 2015

Copy link
Copy Markdown
Contributor Author

How's this?

@garyb

garyb commented Dec 18, 2015

Copy link
Copy Markdown
Member

👍

paf31 added a commit that referenced this pull request Dec 18, 2015
@paf31
Merge pull request #2 from purescript/crash
325f4c9 
Add crash and crashWith
@paf31 paf31 merged commit 325f4c9 into master Dec 18, 2015
@paf31 paf31 deleted the crash branch December 18, 2015 01:30
@paf31

paf31 commented Dec 18, 2015

Copy link
Copy Markdown
Contributor Author

Ok, how do I version this again?

@garyb

garyb commented Dec 18, 2015

Copy link
Copy Markdown
Member

v1.1.0, as it's backwards compatible new features.

@paf31

paf31 commented Dec 18, 2015

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paf31 @garyb