Skip to content

address copilot review on #111: robust luacParse + looser local-count check #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unisay merged 2 commits into from
Jun 23, 2026
Merged

address copilot review on #111: robust luacParse + looser local-count check #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63327a3
address copilot review on PR #111
Unisay Jun 23, 2026
5c07149
address copilot review on PR #112
Unisay Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions test/Language/PureScript/Backend/Lua/Golden/Spec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import Data.List qualified as List
import Data.String qualified as String
import Data.Tagged (Tagged (..))
import Data.Text qualified as Text
import Data.Text.IO qualified as Text.IO
import Language.PureScript.Backend.IR qualified as IR
import Language.PureScript.Backend.IR.FlattenDeepBinds (flattenDeepBinds)
import Language.PureScript.Backend.IR.Linker (LinkMode (..))
Expand Down Expand Up @@ -43,13 +44,15 @@ import Path.IO
, makeAbsolute
, walkDirAccum
, withCurrentDir
, withSystemTempFile
)
import Path.Posix (mkRelFile)
import Prettyprinter (defaultLayoutOptions, layoutPretty)
import Prettyprinter.Render.Text (renderStrict)
import System.FilePath qualified as FilePath
import System.Process.Typed
( ExitCode (..)
, proc
, readProcessInterleaved
, runProcess
, setWorkingDir
Expand Down Expand Up @@ -201,13 +204,17 @@ spec = do
nested ← compileIr (AsModule psModname) uber
flat ← compileIr (AsModule psModname) (flattenDeepBinds uber)

-- The unflattened spine is a single nested expression whose ONLY `local`
-- is the module table, so a load failure here cannot be Lua's
-- 200-locals-per-function cap — it can only be parser nesting.
Text.count "local " nested `shouldBe` 1
-- The error message below is the real discriminator: `luac` reports
-- "too many syntax levels" (nesting), a distinct message from its locals
-- error ("too many local variables"). As corroboration, the unflattened
-- spine is a single nested expression that introduces almost no locals,
-- so it sits far below Lua's 200-locals-per-function cap — that cap
-- cannot be why it fails to load. (A loose bound, not == 1, to stay
-- robust to unrelated module/runtime-setup locals the emitter may add.)
Text.count "local " nested `shouldSatisfy` (< 50)

(nestedExit, nestedOut) ← luacParse "pslua-applyspine-nested" nested
(flatExit, _flatOut) ← luacParse "pslua-applyspine-flat" flat
(nestedExit, nestedOut) ← luacParse nested
(flatExit, _flatOut) ← luacParse flat

nestedExit `shouldSatisfy` (/= ExitSuccess)
nestedOut `shouldSatisfy` ("too many syntax levels" `Text.isInfixOf`)
Expand Down Expand Up @@ -240,14 +247,19 @@ applySpineUberModule n =
(IR.LiteralInt IR.noAnn (fromIntegral i))

{- | Parse-check (no execution) a Lua source with @luac -p@; returns the exit
code and combined output.
code and combined output. Writes to a unique auto-cleaned temp file and invokes
@luac@ via 'proc' (an argv list, no shell), so it is portable and safe against
paths with spaces or concurrent runs.
-}
luacParse ∷ MonadIO m ⇒ String → Text → m (ExitCode, Text)
luacParse name src = liftIO do
let file = "/tmp/" <> name <> ".lua"
writeFileText file src
(code, out) ← readProcessInterleaved (shell ("luac -p " <> file))
pure (code, decodeUtf8 out)
luacParse ∷ Text → IO (ExitCode, Text)
luacParse src =
withSystemTempFile "pslua-nesting.lua" \file handle → do
-- Write through the handle the bracket owns and flush (so the separate
-- `luac` process sees the bytes); the bracket closes it on cleanup.
Text.IO.hPutStr handle src
hFlush handle
(code, out) ← readProcessInterleaved (proc "luac" ["-p", toFilePath file])
pure (code, decodeUtf8 out)

collectGoldenCorefns ∷ MonadIO m ⇒ Path Rel Dir → m [Path Abs File]
collectGoldenCorefns = walkDirAccum
Expand Down
Loading